linux-kernel - Re: [PATCH 3/4] rust: macros: Enable use from macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 18:08:47 -0500
From: "Ethan D. Twardy" <ethan.twardy@...il.com>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: <a.hindborg@...sung.com>, <alex.gaynor@...il.com>,
 <aswinunni01@...il.com>, <benno.lossin@...ton.me>,
 <bjorn3_gh@...tonmail.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
 <linux-kernel@...r.kernel.org>, <ojeda@...nel.org>,
 <rust-for-linux@...r.kernel.org>, <tmgross@...ch.edu>,
 <wedsonaf@...il.com>, <yakoyoku@...il.com>
Subject: Re: [PATCH 3/4] rust: macros: Enable use from macro_rules!

On Mon Jun 24, 2024 at 3:43 AM CDT, Alice Ryhl wrote:
> The actual change looks good to me.
>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
>

Thank you!

> Normally this would be formatted as:
>
> Link: https://doc.rust-lang.org/stable/proc_macro/enum.Delimiter.html [1]
> Signed-off-by: Ethan D. Twardy <ethan.twardy@...il.com>

Ah, thank you for informing me on this :).

> There's a non-hidden empty line between the last constant and
> `macro_rules! pub_no_prefix`. You should either hide the empty line or
> get rid of it, because it will look weird when the example is rendered.
>
>
> Another option would be to keep the import so that the empty line
> separates the import from the macro declaration.

Done! (And the one other identical one, as well).

> I would probably indent [<$prefix $newname:span>] one more time.
>
> Alice

Done, as well. As with PATCH 2/4, these will ship with v2.