[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <81e97c36-e244-4e94-b752-b06334a06db0@quicinc.com>
Date: Wed, 26 Jun 2024 16:36:06 -0700
From: Sagar Cheluvegowda <quic_scheluve@...cinc.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Vinod Koul <vkoul@...nel.org>,
Alexandre Torgue
<alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S.
Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
"Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin
<mcoquelin.stm32@...il.com>,
Russell King <linux@...linux.org.uk>, "Rob
Herring" <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
"Conor
Dooley" <conor+dt@...nel.org>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>, <kernel@...cinc.com>,
Andrew Halaney <ahalaney@...hat.com>, <linux-arm-msm@...r.kernel.org>,
<netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] net: stmmac: Add interconnect support
On 6/26/2024 6:07 AM, Andrew Lunn wrote:
>> + plat->axi_icc_path = devm_of_icc_get(&pdev->dev, "axi");
>> + if (IS_ERR(plat->axi_icc_path)) {
>> + ret = (void *)plat->axi_icc_path;
>
> Casting to a void * seems odd. ERR_PTR()?
>
> Andrew
The output of devm_of_icc_get is a pointer of type icc_path,
i am getting below warning when i try to ERR_PTR instead of Void*
as ERR_PTR will try to convert a long integer to a Void*.
"warning: passing argument 1 of ‘ERR_PTR’ makes integer from pointer without a cast"
Powered by blists - more mailing lists