linux-kernel - Re: [PATCH] staging: nvec: use x instead of x != NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21151f5a-059-538c-3cec-7c40d625c5a8@inria.fr>
Date: Wed, 26 Jun 2024 14:48:03 +1000 (AEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
cc: Tom Mounet <tommounet@...il.com>, Marc Dietrich <marvin24@....de>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, ac100@...ts.launchpad.net, 
    linux-tegra@...r.kernel.org, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: nvec: use x instead of x != NULL



On Wed, 26 Jun 2024, Philipp Hortmann wrote:

> On 6/25/24 22:56, Tom Mounet wrote:
> > Comply with coding rules defined in checkpatch
> >
> > Signed-off-by: Tom Mounet <tommounet@...il.com>
> > ---
> >   drivers/staging/nvec/nvec.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > index e5ca78e57..814eb121c 100644
> > --- a/drivers/staging/nvec/nvec.c
> > +++ b/drivers/staging/nvec/nvec.c
> > @@ -300,7 +300,7 @@ int nvec_write_sync(struct nvec_chip *nvec,
> >   {
> >   	mutex_lock(&nvec->sync_write_mutex);
> >   -	if (msg != NULL)
> > +	if (msg)
> >   		*msg = NULL;
> >     	nvec->sync_write_pending = (data[1] << 8) + data[0];
> > @@ -322,7 +322,7 @@ int nvec_write_sync(struct nvec_chip *nvec,
> >     	dev_dbg(nvec->dev, "nvec_sync_write: pong!\n");
> >   -	if (msg != NULL)
> > +	if (msg)
> >   		*msg = nvec->last_sync_msg;
> >   	else
> >   		nvec_msg_free(nvec, nvec->last_sync_msg);
>
>
> Hi Tom,
>
> what you change in this patch is fine. But the Description is not so lucky.
> Reason is that checkpatch is not defining the coding style. Not at all.
> Sometimes checkpatch is even wrong. The description I like would be:
>
> Use x instead of x != NULL to shorten code.
>
> or
>
> Use x instead of x != NULL to improve readability.
>
> If you send in a second version of this patch please use a change history.
> Description from Dan under:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

How about adding "Issue identified by checkpatch"?  Checkpatch helped find
the problem, so it would be nice to acknowledge that.

julia


>
> Thanks
>
> Bye Philipp
>
>