linux-kernel - Re: [PATCH 2/2] cpufreq: acpi: Mark boost policy as enabled when setting boost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240626050431.mkhfm6rjexspncpe@vireshk-i7>
Date: Wed, 26 Jun 2024 10:34:31 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Mario Limonciello <mario.limonciello@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Gautham R . Shenoy" <gautham.shenoy@....com>,
	Sibi Sankar <quic_sibis@...cinc.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Dhruva Gole <d-gole@...com>, Yipeng Zou <zouyipeng@...wei.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH 2/2] cpufreq: acpi: Mark boost policy as enabled when
 setting boost

On 25-06-24, 23:11, Mario Limonciello wrote:
> When boost is set for CPUs using acpi-cpufreq the policy is not
> updated which can cause boost to be incorrectly not reported.
> 
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> Cc: Sibi Sankar <quic_sibis@...cinc.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Dhruva Gole <d-gole@...com>
> Cc: Yipeng Zou <zouyipeng@...wei.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> v14->v15:
>  * Use Gautham's suggestion instead
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 37f1cdf46d29..bd3f95a7a4fe 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -139,6 +139,7 @@ static int set_boost(struct cpufreq_policy *policy, int val)
>  			 (void *)(long)val, 1);
>  	pr_debug("CPU %*pbl: Core Boosting %s.\n",
>  		 cpumask_pr_args(policy->cpus), str_enabled_disabled(val));
> +	policy->boost_enabled = val;
>  
>  	return 0;
>  }

This is probably the wrong location to make this change as this
function gets called from cpufreq core too, which also sets the
policy->boost_enabled flag.

You should set this separately in the init() function itself after
set_boost() is called.

-- 
viresh