linux-kernel - Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e571211-8921-4548-a093-6c5719c866c4@amd.com>
Date: Wed, 26 Jun 2024 00:55:16 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Vyacheslav Frantsishko <itmymaill@...il.com>,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, broonie@...nel.org
Cc: perex@...ex.cz, lgirdwood@...il.com
Subject: Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA

On 6/26/2024 00:51, Vyacheslav Frantsishko wrote:
> Signed-off-by: Vyacheslav Frantsishko <itmymaill@...il.com>
> 
> The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
> ---
This is a Ryzen 6000 (YC) product, so this does look like the right 
solution.

Your SoB tag is in the wrong place (should be at end of commit message), 
not sure if ALSA guys can fix that while committing or you need to 
re-submit.

But the content looks fine to me otherwise.

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 1760b5d42460..4e3a8ce690a4 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
>   		}
>   	},
> +        {
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> +		}
> +	},
>   	{
>   		.driver_data = &acp6x_card,
>   		.matches = {