| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ad1ced48-4c17-4fe0-b75f-21bb9486f1ac@kernel.org> Date: Wed, 26 Jun 2024 15:27:11 +0900 From: Damien Le Moal <dlemoal@...nel.org> To: Igor Pylypiv <ipylypiv@...gle.com>, Niklas Cassel <cassel@...nel.org> Cc: Tejun Heo <tj@...nel.org>, Hannes Reinecke <hare@...e.de>, "Martin K. Petersen" <martin.petersen@...cle.com>, Jason Yan <yanaijie@...wei.com>, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH v2 1/6] ata: libata-scsi: Do not overwrite valid sense data when CK_COND=1 On 6/25/24 07:12, Igor Pylypiv wrote: > Current ata_gen_passthru_sense() code performs two actions: > 1. Generates sense data based on the ATA 'status' and ATA 'error' fields. > 2. Populates "ATA Status Return sense data descriptor" / "Fixed format > sense data" with ATA taskfile fields. > > The problem is that #1 generates sense data even when a valid sense data > is already present (ATA_QCFLAG_SENSE_VALID is set). Factoring out #2 into > a separate function allows us to generate sense data only when there is > no valid sense data (ATA_QCFLAG_SENSE_VALID is not set). > > As a bonus, we can now delete a FIXME comment in atapi_qc_complete() > which states that we don't want to translate taskfile registers into > sense descriptors for ATAPI. > > Cc: <stable@...r.kernel.org> > Signed-off-by: Igor Pylypiv <ipylypiv@...gle.com> Reviewed-by: Damien Le Moal <dlemoal@...nel.org> -- Damien Le Moal Western Digital Research
Powered by blists - more mailing lists