linux-kernel - Re: [V2,-fixes] riscv: kexec: Avoid deadlock in kexec crash path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 15:32:20 +0900
From: takakura@...inux.co.jp
To: songshuaishuai@...ylab.org,
	alex@...ti.fr,
	paul.walmsley@...ive.com,
	palmer@...belt.com
Cc: aou@...s.berkeley.edu,
	bhe@...hat.com,
	guoren@...nel.org,
	xianting.tian@...ux.alibaba.com,
	akpm@...ux-foundation.org,
	takakura@...inux.co.jp,
	linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [V2,-fixes] riscv: kexec: Avoid deadlock in kexec crash path

On Wed, 26 June 2024, Song Shuai wrote:
>If the kexec crash code is called in the interrupt context, the
>machine_kexec_mask_interrupts() function will trigger a deadlock while
>trying to acquire the irqdesc spinlock and then deactivate irqchip in
>irq_set_irqchip_state() function.
>
>Unlike arm64, riscv only requires irq_eoi handler to complete EOI and
>keeping irq_set_irqchip_state() will only leave this possible deadlock
>without any use. So we simply remove it.
>
>Link: https://lore.kernel.org/linux-riscv/20231208111015.173237-1-songshuaishuai@tinylab.org/
>Fixes: b17d19a5314a ("riscv: kexec: Fixup irq controller broken in kexec crash path")
>Signed-off-by: Song Shuai <songshuaishuai@...ylab.org>
>---
>Changes since V1:
>https://lore.kernel.org/linux-riscv/20231208111015.173237-1-songshuaishuai@tinylab.org/
>- update the commit log as @Ryo elaborated 
>- rebase on Linux 6.10-rc3

Reviewed-by: Ryo Takakura <takakura@...inux.co.jp>