[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <327d6dd1-3f31-4b49-96f0-afd754eae086@kernel.org>
Date: Wed, 26 Jun 2024 10:17:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Damien Le Moal <dlemoal@...nel.org>,
Niklas Cassel <cassel@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: add
fsl,ls1046a-ahci and fsl,ls1012a-ahci
On 25/06/2024 22:57, Frank Li wrote:
> Add compatible string 'fsl,ls1046a-ahci' and 'fsl,ls1012a-ahci' compatible
> string. Allow 'fsl,ls1012a-ahci' fallback to 'fsl,ls1043a-ahci'.
>
> ls1046a ahci ecc disable bit is difference with other chips.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> .../devicetree/bindings/ata/fsl,ahci.yaml | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> index 162b3bb5427ed..a244bc603549d 100644
> --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> @@ -11,13 +11,18 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - fsl,ls1021a-ahci
> - - fsl,ls1043a-ahci
> - - fsl,ls1028a-ahci
> - - fsl,ls1088a-ahci
> - - fsl,ls2080a-ahci
> - - fsl,lx2160a-ahci
> + oneOf:
> + - items:
> + - const: fsl,ls1012a-ahci
> + - const: fsl,ls1043a-ahci
> + - enum:
> + - fsl,ls1021a-ahci
> + - fsl,ls1043a-ahci
> + - fsl,ls1046a-ahci
Where is the driver change for this?
Your commit does not explain why you are doing it and without driver
change adding new support it is not obvious. This probably applies to
all your patches.
Best regards,
Krzysztof
Powered by blists - more mailing lists