[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8c820056-ff20-441a-af7f-17d184c0b396@kernel.org>
Date: Wed, 26 Jun 2024 10:28:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Thomas Gleixner <tglx@...utronix.de>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"open list:IRQCHIP DRIVERS" <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: convert
fsl,ls-scfg-msi to yaml
On 25/06/2024 22:10, Frank Li wrote:
> Convert device tree binding fsl,ls-scfg-msi to yaml format.
>
> Additional changes:
> - Include gic.h and use predefined macro in example.
> - Remove label in example.
> - Change node name to interrupt-controller in example.
> - Fix error in example.
> - ls1046a allow 4 irqs, other platform only 1 irq.
>
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,ls1021a-msi
> + - fsl,ls1043a-msi
> + - fsl,ls1046a-msi
> + - fsl,ls1043a-v1.1-msi
> + - fsl,ls1012a-msi
Keep the list ordered alpha-numerically.
> +
> + reg:
> + maxItems: 1
> +
> + msi-controller: true
No msi-cells?
> +
> + interrupts:
> + minItems: 1
> + maxItems: 4
Please describe the interrupts (items: - description: ...)
> +
> +required:
> + - compatible
> + - reg
> + - msi-controller
> + - interrupts
> +
> +additionalProperties: false
This goes after allOf: block.
> +
> +allOf:
No $ref to msi-controller.yaml?
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,ls1046a-msi
> + then:
> + properties:
> + interrupts:
> + minItems: 4
> + else:
> + properties:
> + interrupts:
> + maxItems: 1
Best regards,
Krzysztof
Powered by blists - more mailing lists