linux-kernel - Re: [PATCH] ASoC: dt-bindings: realtek,rt5677: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <254c5205-06d6-49e2-a703-b6a33c7cb1a1@kernel.org>
Date: Wed, 26 Jun 2024 11:05:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: realtek,rt5677: Convert to dtschema

On 25/06/2024 11:22, Animesh Agarwal wrote:
> Convert the RT5677 audio CODEC bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> Cc: Daniel Baluta <daniel.baluta@....com>

Thank you for your patch. There is something to discuss/improve.

> +  realtek,gpio-config:
> +    description: |
> +      Array of six 8bit elements that configures GPIO.
> +      0 - floating (reset value)
> +      1 - pull down
> +      2 - pull up
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 6
> +    maxItems: 6
> +    items:
> +      maximum: 2
> +
> +patternProperties:
> +  "^realtek,in[1-2]-differential$":

In the future, please use consistent quotes, so either ' or ".

> +    type: boolean
> +    description: Indicate MIC1/2 input are differential, rather than
> +      single-ended.
> +
> +  "^realtek,lout[1-3]-differential$":
> +    type: boolean
> +    description: Indicate LOUT1/2/3 outputs are differential, rather than
> +      single-ended.
> +
> +  "^realtek,jd[1-3]-gpio$":
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # OFF
> +      - 1 # GPIO1 for jd1 and GPIO4 for jd2.
> +      - 2 # GPIO2 for jd1 and GPIO5 for jd2.
> +      - 3 # GPIO3 for jd1 and GPIO6 for jd2.


I don't quite get it. What about jd3? I think it would be clearer if
these were listed as properties, not pattern properties.

> +    description: Configures GPIO Mic Jack detection 1, 2 and 3.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - gpio-controller
> +  - '#gpio-cells'
> +
> +unevaluatedProperties: false

Best regards,
Krzysztof