linux-kernel - Re: [PATCH v2 4/5] x86/mce: Define mce_prep_record() helpers for common and per-CPU fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240626014542.GC1086@yaz-khff2.amd.com>
Date: Tue, 25 Jun 2024 21:45:42 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Nikolay Borisov <nik.borisov@...e.com>
Cc: linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	tony.luck@...el.com, x86@...nel.org, avadhut.naik@....com,
	john.allen@....com
Subject: Re: [PATCH v2 4/5] x86/mce: Define mce_prep_record() helpers for
 common and per-CPU fields

On Tue, Jun 25, 2024 at 04:19:40PM +0300, Nikolay Borisov wrote:

[...]

> > +
> > +void mce_prep_record_per_cpu(unsigned int cpu, struct mce *m)
> > +{
> > +	m->cpu		= cpu;
> > +	m->extcpu	= cpu;
> > +	m->apicid	= cpu_data(m->extcpu).topo.initial_apicid;
> > +	m->microcode	= cpu_data(m->extcpu).microcode;
> > +	m->ppin		= cpu_data(m->extcpu).ppin;
> 
> nit: Similar to tglx's feedback for patch 2 you could use topology_ppin()
> 
> > +	m->socketid	= cpu_data(m->extcpu).topo.pkg_id;
> nit: topology_physical_package_id()
> 
>

Yes, will update both.

Thanks,
Yazen