[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <676e4acc-3999-4042-bace-2ba1ab1c3943@ideasonboard.com>
Date: Wed, 26 Jun 2024 13:10:39 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Aradhya Bhatia <a-bhatia1@...com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Jyri Sarha <jyri.sarha@....fi>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: DRI Development List <dri-devel@...ts.freedesktop.org>,
Linux Kernel List <linux-kernel@...r.kernel.org>,
Dominik Haller <d.haller@...tec.de>, Sam Ravnborg <sam@...nborg.org>,
Thierry Reding <treding@...dia.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
Praneeth Bajjuri <praneeth@...com>, Udit Kumar <u-kumar1@...com>,
Devarsh Thakkar <devarsht@...com>, Jayesh Choudhary <j-choudhary@...com>,
Jai Luthra <j-luthra@...com>
Subject: Re: [PATCH v4 02/11] drm/bridge: cdns-dsi: Move to
devm_drm_of_get_bridge()
On 22/06/2024 14:09, Aradhya Bhatia wrote:
> Instead of manually finding the next bridge/panel, and maintaining the
> panel-bridge (in-case the next entity is a panel), switch to using the
> automatically managing devm_drm_of_get_bridge() API.
>
> Drop the drm_panel support completely from the driver while at it.
>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@...com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Tomi
> ---
> .../gpu/drm/bridge/cadence/cdns-dsi-core.c | 28 ++-----------------
> .../gpu/drm/bridge/cadence/cdns-dsi-core.h | 2 --
> 2 files changed, 3 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index b016f2ba06bb..5159c3f0853e 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -920,8 +920,6 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host,
> struct cdns_dsi_output *output = &dsi->output;
> struct cdns_dsi_input *input = &dsi->input;
> struct drm_bridge *bridge;
> - struct drm_panel *panel;
> - struct device_node *np;
> int ret;
>
> /*
> @@ -939,26 +937,10 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host,
> /*
> * The host <-> device link might be described using an OF-graph
> * representation, in this case we extract the device of_node from
> - * this representation, otherwise we use dsidev->dev.of_node which
> - * should have been filled by the core.
> + * this representation.
> */
> - np = of_graph_get_remote_node(dsi->base.dev->of_node, DSI_OUTPUT_PORT,
> - dev->channel);
> - if (!np)
> - np = of_node_get(dev->dev.of_node);
> -
> - panel = of_drm_find_panel(np);
> - if (!IS_ERR(panel)) {
> - bridge = drm_panel_bridge_add_typed(panel,
> - DRM_MODE_CONNECTOR_DSI);
> - } else {
> - bridge = of_drm_find_bridge(np);
> - if (!bridge)
> - bridge = ERR_PTR(-EINVAL);
> - }
> -
> - of_node_put(np);
> -
> + bridge = devm_drm_of_get_bridge(dsi->base.dev, dsi->base.dev->of_node,
> + DSI_OUTPUT_PORT, dev->channel);
> if (IS_ERR(bridge)) {
> ret = PTR_ERR(bridge);
> dev_err(host->dev, "failed to add DSI device %s (err = %d)",
> @@ -968,7 +950,6 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host,
>
> output->dev = dev;
> output->bridge = bridge;
> - output->panel = panel;
>
> /*
> * The DSI output has been properly configured, we can now safely
> @@ -984,12 +965,9 @@ static int cdns_dsi_detach(struct mipi_dsi_host *host,
> struct mipi_dsi_device *dev)
> {
> struct cdns_dsi *dsi = to_cdns_dsi(host);
> - struct cdns_dsi_output *output = &dsi->output;
> struct cdns_dsi_input *input = &dsi->input;
>
> drm_bridge_remove(&input->bridge);
> - if (output->panel)
> - drm_panel_bridge_remove(output->bridge);
>
> return 0;
> }
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h
> index ca7ea2da635c..5db5dbbbcaad 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h
> @@ -10,7 +10,6 @@
>
> #include <drm/drm_bridge.h>
> #include <drm/drm_mipi_dsi.h>
> -#include <drm/drm_panel.h>
>
> #include <linux/bits.h>
> #include <linux/completion.h>
> @@ -21,7 +20,6 @@ struct reset_control;
>
> struct cdns_dsi_output {
> struct mipi_dsi_device *dev;
> - struct drm_panel *panel;
> struct drm_bridge *bridge;
> union phy_configure_opts phy_opts;
> };
Powered by blists - more mailing lists