linux-kernel - Re: [PATCH v2 1/2] power: supply: samsung-sdi-battery: Constify struct power_supply_vbat_ri

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ-DOLV1ZHALCDKaUjj4HjwX_qLJ9GttKMvrRJ867q64Q@mail.gmail.com>
Date: Wed, 26 Jun 2024 12:37:53 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Sebastian Reichel <sre@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: samsung-sdi-battery: Constify
 struct power_supply_vbat_ri_table

On Sun, Jun 23, 2024 at 8:45 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:

> 'struct power_supply_vbat_ri_table' are not modified in this driver.
>
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
>
> In order to do it, some code also needs to be adjusted to this new const
> qualifier.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text    data     bss     dec     hex filename
>     955    7664       0    8619    21ab drivers/power/supply/samsung-sdi-battery.o
>
> After:
> =====
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text    data     bss     dec     hex filename
>    4055    4584       0    8639    21bf drivers/power/supply/samsung-sdi-battery.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Really neat!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij