linux-kernel - Re: [PATCH] ARM: spitz: fix GPIO assignment for backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 12:43:26 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Haojian Zhuang <haojian.zhuang@...il.com>, Daniel Mack <daniel@...que.org>, 
	Robert Jarzmik <robert.jarzmik@...e.fr>, Russell King <linux@...linux.org.uk>, 
	Arnd Bergmann <arnd@...db.de>, Lee Jones <lee@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: spitz: fix GPIO assignment for backlight

On Sat, Jun 22, 2024 at 10:42 PM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:

> GPIOs controlling backlight on Spitz and Akita are coming from GPIO
> expanders, not the pxa27xx-gpio block, correct it.
>
> Additionally GPIO lookup tables operate with pin numbers rather than
> legacy GPIO numbers, fix that as well. Use raw numbers instead of legacy
> GPIO names to avoid confusion.
>
> Fixes: ee0c8e494cc3 ("backlight: corgi: Convert to use GPIO descriptors")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>
> Linus, I am not sure if this is actually an issue, but I strongly
> suspect that it is. I have no hardware, so no means to test it, sorry.

Looks right to me,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Maybe you can send it directly to soc@...nel.org so it can be applied?

Yours,
Linus Walleij