linux-kernel - RE: [PATCH 1/1] iommu/vt-d: Downgrade warning for pre-enabled IR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 02:08:16 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Liu,
 Yi L" <yi.l.liu@...el.com>, Jacob Pan <jacob.jun.pan@...ux.intel.com>
CC: Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Paul Menzel
	<pmenzel@...gen.mpg.de>
Subject: RE: [PATCH 1/1] iommu/vt-d: Downgrade warning for pre-enabled IR

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Tuesday, June 25, 2024 12:39 PM
> 
> Emitting a warning is overkill in intel_setup_irq_remapping() since the
> interrupt remapping is pre-enabled. For example, there's no guarantee
> that kexec will explicitly disable interrupt remapping before booting a
> new kernel. As a result, users are seeing warning messages like below
> when they kexec boot a kernel, though there is nothing wrong:
> 
>  DMAR-IR: IRQ remapping was enabled on dmar18 but we are not in kdump
> mode
>  DMAR-IR: IRQ remapping was enabled on dmar17 but we are not in kdump
> mode
>  DMAR-IR: IRQ remapping was enabled on dmar16 but we are not in kdump
> mode
>  ... ...
> 
> Downgrade the severity of this message to avoid user confusion.
> 
> CC: Paul Menzel <pmenzel@...gen.mpg.de>
> Link: https://lore.kernel.org/linux-iommu/5517f76a-94ad-452c-bae6-
> 34ecc0ec4831@...gen.mpg.de/
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>