linux-kernel - Re: invalid vht params rate 1920 100kbps nss 2 mcs 9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 13:48:01 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Kalle Valo <kvalo@...nel.org>
Cc: Baochen Qiang <quic_bqiang@...cinc.com>,
 James Prestwood <prestwoj@...il.com>, linux-wireless@...r.kernel.org,
 ath10k@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>,
 Hans de Goede <hdegoede@...hat.com>,
 Kai-Heng Feng <kai.heng.feng@...onical.com>,
 Hui Wang <hui.wang@...onical.com>
Subject: Re: invalid vht params rate 1920 100kbps nss 2 mcs 9

Dear Kalle,


Am 26.06.24 um 12:16 schrieb Kalle Valo:
> Paul Menzel writes:
> 
>> Am 26.06.24 um 10:53 schrieb Baochen Qiang:
>>
>>> OK, there are two issues here:
>>> 1. invalid HT rate: "ath10k_pci 0000:02:00.0: invalid ht params rate 1440 100kbps nss 2 mcs 7".
>>> As commented by Wen quite some time ago, this has been fixed from
>>> firmware side, and firmware newer than [ver:241] has the fix
>>> included.
> 
> I assume this means that the firmware version
> WLAN.RM.4.4.1-00241-QCARMSWPZ-1 or newer has the fix.
> 
>>> 2. invaid VHT rate: "ath10k_pci 0000:3a:00.0: invalid vht params rate 1920 100kbps nss 2 mcs 9".
>>> After checking with firmware team, I thought this is because there is
>>> a mismatch in rate definition between host and firmware: In host, the
>>> rate for 'nss 2 mcs 9' is defined as {1560, 1733}, see
>>> supported_vht_mcs_rate_nss2[]. While in firmware this is defined as
>>> {1730, 1920}. So seems we can update host definition to avoid this
>>> issue.
>> 
>> Looking through the logs since May 2024, I have four different logs:
>>
>> 1.  invalid vht params rate 878 100kbps nss 3 mcs 2
>> 2.  invalid vht params rate 960 100kbps nss 1 mcs 9
>> 3.  invalid vht params rate 1730 100kbps nss 2 mcs 9
>> 4.  invalid vht params rate 1920 100kbps nss 2 mcs 9
>>
>> I believe it’s only happening with Cisco networks. I am happy to test
>> a patch.
>>
>> By the way, is the firmware version logged by Linux?
>>
>>      ath10k_pci 0000:3a:00.0: qca6174 hw3.2 target 0x05030000 chip_id 0x00340aff sub 1a56:1535
>>      ath10k_pci 0000:3a:00.0: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0
>>      ath10k_pci 0000:3a:00.0: firmware ver WLAN.RM.4.4.1-00288- api 6 features wowlan,ignore-otp,mfp crc32 bf907c7c
>>      ath10k_pci 0000:3a:00.0: board_file api 2 bmi_id N/A crc32 d2863f91
>>      ath10k_pci 0000:3a:00.0: htt-ver 3.87 wmi-op 4 htt-op 3 cal otp max-sta 32 raw 0 hwcrypto 1
>>
>> Is it 4.4.1-00288?
> 
> Yes, that should be WLAN.RM.4.4.1-00288-QCARMSWPZ-1. But I don't know
> why 'QCARMSWPZ-1' is not printed by ath10k, maybe we have a bug
> somewhere.
> 
>> How can I find the file in `/lib/firmware/`?
> 
> It should be in ath10k/QCA6174/hw3.0/firmware-6.bin.
> 
> All firmware releases are available here:
> 
> https://git.codelinaro.org/clo/ath-firmware/ath10k-firmware/-/tree/main/QCA6174/hw3.0/4.4.1?ref_type=heads
> 
> And more info here:
> 
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/firmware

Thank you. It looks like the latest firmware version is 309, and Debian 
sid/unstable still ships version 288 in *firmware-atheros* 20230625-2 [1].

Unfortunately, there does not seem to be a change-log for version 309 
(or any version for that matter). I am going to manually copy it anyway, 
but it’d be nice, if I knew what to expect. ;-)


Kind regards,

Paul


[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1074308
      "firmware-atheros: QCA 6174: Newest version 309 missing"