linux-kernel - Re: [PATCH] drm/radeon: fix null pointer dereference in radeon_add_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 14:00:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Xinhui Pan <Xinhui.Pan@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/radeon: fix null pointer dereference in
 radeon_add_common_modes

> In radeon_add_common_modes(), the return value of drm_cvt_mode() is
> assigned to mode, which will lead to a possible NULL pointer dereference
> on failure of drm_cvt_mode(). Add a check to avoid npd.

1. Can a wording approach (like the following) be a better change description?

   A null pointer is stored in the local variable “mode” after a call
   of the function “drm_cvt_mode” failed. This pointer was passed to
   a subsequent call of the function “drm_mode_probed_add” where an undesirable
   dereference will be performed then.
   Thus add a corresponding return value check.

2. Would you like to add any tags (like “Fixes” and “Cc”) accordingly?

3. How do you think about to append parentheses to the function name
   in the summary phrase?

Regards,
Markus