linux-kernel - Re: [PATCH v2 2/5] rosebush: Add new data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnwUqpHXGpzK2dEV@casper.infradead.org>
Date: Wed, 26 Jun 2024 14:16:26 +0100
From: Matthew Wilcox <willy@...radead.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	maple-tree@...ts.infradead.org
Subject: Re: [PATCH v2 2/5] rosebush: Add new data structure

On Tue, Jun 25, 2024 at 11:36:06PM +0000, Dr. David Alan Gilbert wrote:
> > +Overview
> > +========
> > +
> > +Rosebush is a hashtable, different from the rhashtable.  It is scalable
> > +(one spinlock per bucket), resizing in two dimensions (number and size
> > +of buckets),
> 
> Is that old - I thought the cover letter said v2 had fixed size buckets?

Thanks.

 Rosebush is a hashtable, different from the rhashtable.  It is scalable
-(one spinlock per bucket), resizing in two dimensions (number and size
-of buckets), and concurrent (can be iterated under the RCU read lock).
-It is designed to minimise dependent cache misses, which can stall a
-modern CPU for thousands of instructions.
+(one spinlock per bucket), resizing (number of buckets), and concurrent
+(can be iterated under the RCU read lock).  It is designed to minimise
+dependent cache misses, which can stall a modern CPU for thousands
+of instructions.