linux-kernel - Re: [PATCH] selftests/fpu: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 08:22:28 -0500
From: Samuel Holland <samuel.holland@...ive.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Huacai Chen <chenhuacai@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Jonathan Corbet <corbet@....net>, Masahiro Yamada <masahiroy@...nel.org>,
 Michael Ellerman <mpe@...erman.id.au>, Nathan Chancellor
 <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>,
 Palmer Dabbelt <palmer@...osinc.com>, Russell King <linux@...linux.org.uk>,
 Thomas Gleixner <tglx@...utronix.de>, WANG Xuerui <git@...0n.name>,
 Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro

On 2024-06-22 9:55 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 now reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_fpu.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Fixes: 9613736d852d ("selftests/fpu: move FP code to a separate translation unit")
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  lib/test_fpu_glue.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/test_fpu_glue.c b/lib/test_fpu_glue.c
> index eef282a2715f..074f30301f29 100644
> --- a/lib/test_fpu_glue.c
> +++ b/lib/test_fpu_glue.c
> @@ -59,4 +59,5 @@ static void __exit test_fpu_exit(void)
>  module_init(test_fpu_init);
>  module_exit(test_fpu_exit);
>  
> +MODULE_DESCRIPTION("Test cases for floating point operations");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240622-md-i386-lib-test_fpu_glue-437927d4afe3
> 

Reviewed-by: Samuel Holland <samuel.holland@...ive.com>