linux-kernel - Re: [PATCH v2] scsi: sd: Keep the discard mode stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1ed8jglom.fsf@ca-mkp.ca.oracle.com>
Date: Wed, 26 Jun 2024 22:43:46 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Li Feng <fengli@...rtx.com>
Cc: Christoph Hellwig <hch@...radead.org>,
        "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,
        linux-kernel@...r.kernel.org (open list),
        linux-scsi@...r.kernel.org (open list:SCSI SUBSYSTEM),
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jens Axboe
 <axboe@...nel.dk>
Subject: Re: [PATCH v2] scsi: sd: Keep the discard mode stable


Li,

> The discard mode has been negotiated during the SCSI probe. If the
> mode is temporarily changed from UNMAP to WRITE SAME with UNMAP, IO
> ERROR may occur because the target may not implement WRITE SAME with
> UNMAP. Keep the discard mode stable to fix this issue.

This is fine with me. It's a subset of what I have pending in my
discovery series but it doesn't look like that will ready in time for
6.11. So let's just grab this for now.

Jens: Probably easiest if you take this through the block-limits branch.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering