linux-kernel - Re: [PATCH] vfs: rename parent_ino to d_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240627-bekommen-fazit-59144d1745cd@brauner>
Date: Thu, 27 Jun 2024 18:30:22 +0200
From: Christian Brauner <brauner@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] vfs: rename parent_ino to d_parent_ino and make it use
 RCU

On Thu, Jun 27, 2024 at 06:11:52PM GMT, Mateusz Guzik wrote:
> The routine is used by procfs through dir_emit_dots.
> 
> The combined RCU and lock fallback implementation is too big for an
> inline. Given that the routine takes a dentry argument fs/dcache.c seems
> like the place to put it in.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>
> ---
> 
> this shows up with stress-ng --getdent (as one of many things)
> 
> build-tested with first adding d_parent_ino, then building allmodconfig
> and fixing failures as they pop up. by the end of it grep shows no
> remaining occurences, so i don't believe there will be any build regressions.
> 
> scheme borrowed from dget_parent

I like it.