linux-kernel - Re: [PATCH v2 1/2] scsi: ufs: Suspend clk scaling on no request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75bca322-43df-9d4e-3dd8-804d9aa7f851@quicinc.com>
Date: Thu, 27 Jun 2024 22:29:33 +0530
From: Ram Prakash Gupta <quic_rampraka@...cinc.com>
To: Bart Van Assche <bvanassche@....org>,
        "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
	<martin.petersen@...cle.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>
CC: Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_cang@...cinc.com>,
        <quic_nguyenb@...cinc.com>, <quic_pragalla@...cinc.com>,
        <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Suspend clk scaling on no request



On 6/27/2024 10:05 PM, Bart Van Assche wrote:
> On 6/27/24 1:37 AM, Ram Prakash Gupta wrote:
>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
>> index 1b65e6ae4137..9f935e5c60e8 100644
>> --- a/drivers/ufs/core/ufshcd.c
>> +++ b/drivers/ufs/core/ufshcd.c
>> @@ -1560,7 +1560,8 @@ static int ufshcd_devfreq_target(struct device 
>> *dev,
>>           ktime_to_us(ktime_sub(ktime_get(), start)), ret);
>>   out:
>> -    if (sched_clk_scaling_suspend_work && !scale_up)
>> +    if (sched_clk_scaling_suspend_work &&
>> +            (!scale_up || hba->clk_scaling.suspend_on_no_request))
>>           queue_work(hba->clk_scaling.workq,
>>                  &hba->clk_scaling.suspend_work);
>> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
>> index bad88bd91995..c14607f2890b 100644
>> --- a/include/ufs/ufshcd.h
>> +++ b/include/ufs/ufshcd.h
>> @@ -457,6 +457,7 @@ struct ufs_clk_scaling {
>>       bool is_initialized;
>>       bool is_busy_started;
>>       bool is_suspended;
>> +    bool suspend_on_no_request;
>>   };
>>   #define UFS_EVENT_HIST_LENGTH 8
> 
> Who are the other vendors that support clock scaling? I'm asking because
> I don't think that the behavior change introduced by this patch should
> depend on the SoC vendor.
> 
> Thanks,
> 
> Bart.

Hi Bart,

I guess, Mediatek is one vendor who is having this feature in use as I
see some fixes coming from Peter with respect to clk scaling, where some
power regression on mediatek chipsets were addressed.

Please check below link for background of this change and reason to keep
it vendor specific.
https://www.spinics.net/lists/linux-scsi/msg193591.html

Thanks,
Ram