linux-kernel - Re: [PATCH] Perf: Calling available function for stats printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWyDXFPi4Jn1PYTbVCRO_f_8gcp6aaB10=6CfqDdXgkLQ@mail.gmail.com>
Date: Thu, 27 Jun 2024 10:17:36 -0700
From: Ian Rogers <irogers@...gle.com>
To: Abhishek Dubey <adubey@...ux.ibm.com>
Cc: linuxppc-dev@...ts.ozlabs.org, naveen.n.rao@...ux.vnet.ibm.com, 
	mpe@...erman.id.au, npiggin@...il.com, peterz@...radead.org, mingo@...hat.com, 
	namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, adrian.hunter@...el.com, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org, chu howard <howardchu95@...il.com>
Subject: Re: [PATCH] Perf: Calling available function for stats printing

On Thu, Jun 27, 2024 at 6:37 AM Abhishek Dubey <adubey@...ux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@...ux.ibm.com>

Thanks Abishek, the change looks good but it needs to be rebased on
top of Commit 411ee13598ef ("perf hist: Add symbol_conf.skip_empty") -
https://lore.kernel.org/r/20240607202918.2357459-4-namhyung@kernel.org
. Recently Howard Chu wrote a guide on this:
https://sberm.cn/blog/how-to-contrib-perf

Another small issue is the commit message should be "perf report: ..."
rather than "Perf: ...".

Thanks,
Ian