linux-kernel - [PATCH v2 3/4] i2c: smbus: drop warning about muxed segments requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240627-piix4-spd-v2-3-617ce47b8ff4@weissschuh.net>
Date: Thu, 27 Jun 2024 19:48:13 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Andi Shyti <andi.shyti@...nel.org>, Jean Delvare <jdelvare@...e.com>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Guenter Roeck <linux@...ck-us.net>, 
 Wolfram Sang <wsa+renesas@...g-engineering.com>, 
 Heiner Kallweit <hkallweit1@...il.com>, 
 Thomas Weißschuh <linux@...ssschuh.net>
Subject: [PATCH v2 3/4] i2c: smbus: drop warning about muxed segments
 requirement

The check and warning are very specific to the SPD usage of the i801
driver. That was fine as long as i801 was the only caller of
i2c_register_spd(). Now that piix4 also wants to do the same the check
and warning are not accurate anymore.
Instead of introducing a more complicated calling protocol only to print
a warning, drop the warning.

Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
---
 drivers/i2c/i2c-smbus.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index cdbb95fe104e..f0ac35fd0c5a 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -356,10 +356,6 @@ void i2c_register_spd(struct i2c_adapter *adap)
 	 * If more slots are present either muxed or multiple busses are
 	 * necessary or the additional slots are ignored.
 	 */
-	if (!i2c_parent_is_i2c_adapter(adap) && slot_count > 8) {
-		dev_warn(&adap->dev,
-			 "More than 8 memory slots on a single bus, contact i801 maintainer to add missing mux config\n");
-	}
 	slot_count = min(slot_count, 8);
 
 	/*

-- 
2.45.2