linux-kernel - Re: [PATCH V3] cgroup/cpuset: Prevent UAF in proc_cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zn2vjVNnIcUN8lXM@slm.duckdns.org>
Date: Thu, 27 Jun 2024 08:29:33 -1000
From: Tejun Heo <tj@...nel.org>
To: Michal Koutný <mkoutny@...e.com>
Cc: Chen Ridong <chenridong@...wei.com>, lizefan.x@...edance.com,
	hannes@...xchg.org, longman@...hat.com, adityakali@...gle.com,
	sergeh@...nel.org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] cgroup/cpuset: Prevent UAF in proc_cpuset_show()

Hello,

On Thu, Jun 27, 2024 at 11:46:10AM +0200, Michal Koutný wrote:
> Your patch should work thanks to the rcu_read_lock and
> cgroup_free_root/kfree_rcu and the `if (css->cgroup)` guard is
> unnecessary.
> 
> So the patch is a functional fix, the reasoning in commit message is
> little off. Not sure if Tejun rebases his for-6.10-fixes (with a
> possible v4), full fixup commit for this may not be worthy.

This one's on the top. If Chen can send me a patch with updated description,
I will replace the patch.

Thanks.

-- 
tejun