linux-kernel - Re: [RFC PATCH 4/7] mm: move internal core VMA manipulation functions to own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zimu7rfc7gf2pdsc4ic3ch3ype7i3dcmh3owj3uigohag36gv7@f4ouk7j7cdim>
Date: Thu, 27 Jun 2024 15:46:09 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Lorenzo Stoakes <lstoakes@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Vlastimil Babka <vbabka@...e.cz>, Matthew Wilcox <willy@...radead.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [RFC PATCH 4/7] mm: move internal core VMA manipulation
 functions to own file

* Lorenzo Stoakes <lstoakes@...il.com> [240627 15:41]:
> On Thu, Jun 27, 2024 at 01:56:12PM -0400, Liam R. Howlett wrote:
> > * Lorenzo Stoakes <lstoakes@...il.com> [240627 06:39]:
> > > This patch introduces vma.c and moves internal core VMA manipulation
> > > functions to this file from mmap.c.
> > >
> > > This allows us to isolate VMA functionality in a single place such that we
> > > can create userspace testing code that invokes this functionality in an
> > > environment where we can implement simple unit tests of core functionality.
> > >
> > > This patch ensures that core VMA functionality is explicitly marked as such
> > > by its presence in mm/vma.h.
> > >
> > > It also places the header includes required by vma.c in vma_internal.h,
> > > which is simply imported by vma.c. This makes the VMA functionality
> > > testable, as userland testing code can simply stub out functionality
> > > as required.
> >
> > My initial thought on vma_internal.h would be to contain the number of
> > 'helper' functions and internal structures while mm/vma.h would have the
> > interface.
> 
> This is what I've done though?
> 

Yes, for the most part.  I was just surprised to see all the #includes
move.  It makes sense though as it saves a huge number of stubs/#define
of header guards.

...

Thanks,
Liam