linux-kernel - Re: [PATCH net-next v3] enic: add ethtool get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EC0094DD-107B-4251-A4A6-AB0C77D6367D@nutanix.com>
Date: Thu, 27 Jun 2024 20:10:04 +0000
From: Jon Kohler <jon@...anix.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Christian Benvenuti <benve@...co.com>, Satish Kharat <satishkh@...co.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] enic: add ethtool get_channel support



> On Jun 26, 2024, at 10:10 PM, Jakub Kicinski <kuba@...nel.org> wrote:
> 
> On Tue, 25 Jun 2024 17:53:38 -0700 Jon Kohler wrote:
>> + channels->combined_count = 1;
> 
> clang complains about the lack of break or fallthrough here,
> as annoying and pointless of a warning as it is :(

Ah, right - fixed in v4 just now

> 
> drivers/net/ethernet/cisco/enic/enic_ethtool.c:627:2: note: insert 'break;' to avoid fall-through
>  627 |         default:
>      |         ^
>      |         break; 
> 
>> + default:
>> + break;
> -- 
> pw-bot: cr