linux-kernel - Re: [PATCH v2] block: flush all throttled bios when deleting the cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zn3O47DUoLliwbWm@slm.duckdns.org>
Date: Thu, 27 Jun 2024 10:43:15 -1000
From: Tejun Heo <tj@...nel.org>
To: Li Lingfeng <lilingfeng@...weicloud.com>
Cc: josef@...icpanda.com, hch@....de, axboe@...nel.dk, mkoutny@...e.com,
	cgroups@...r.kernel.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, yangerkun@...wei.com,
	yukuai1@...weicloud.com, houtao1@...wei.com, yi.zhang@...wei.com,
	lilingfeng3@...wei.com
Subject: Re: [PATCH v2] block: flush all throttled bios when deleting the
 cgroup

Hello, Li.

On Thu, Jun 27, 2024 at 10:26:06PM +0800, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@...wei.com>
> 
> When a process migrates to another cgroup and the original cgroup is deleted,
> the restrictions of throttled bios cannot be removed. If the restrictions
> are set too low, it will take a long time to complete these bios.
> 
> Refer to the process of deleting a disk to remove the restrictions and
> issue bios when deleting the cgroup.
> 
> This makes difference on the behavior of throttled bios:
> Before: the limit of the throttled bios can't be changed and the bios will
> complete under this limit;
> Now: the limit will be canceled and the throttled bios will be flushed
> immediately.

I'm not necessarily against this but the description doesn't explain why
this is better either. Can you please detail why this behavior is better?

Thanks.

-- 
tejun