linux-kernel - Re: [PATCH v2 5/5] kunit: Merge assertion test into kunit-test.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c63690e7-53b6-4751-ab89-40469d68275d@gmail.com>
Date: Thu, 27 Jun 2024 21:46:58 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Rae Moar <rmoar@...gle.com>
Cc: brendan.higgins@...ux.dev, davidgow@...gle.com,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH v2 5/5] kunit: Merge assertion test into kunit-test.c

On 6/21/24 22:38, Rae Moar wrote:
> On Tue, Jun 18, 2024 at 1:03 PM Ivan Orlov <ivan.orlov0322@...il.com> wrote:
>>
>> Since assert_test covers the part of the KUnit core (the assertion
>> formatting functions), I believe it would be better to have it merged
>> into kunit-test (as it is done for other tests for the KUnit core).
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
> 
> Hello!
> 
> This looks good to me. I don't know if it was necessary to move the
> assert tests but I definitely see the reasoning. Happy with this as it
> is. There are a few checkpatch warnings I have mentioned below but I
> think the use case makes it necessary.
> 
> Reviewed-by: Rae Moar <rmoar@...gle.com>
> 
> Thanks!
> -Rae
> 

Hi Rae,

Thank you so much for the review, and sorry for the late reply ( I've 
been on vacation this week, and didn't have access to my inbox :( ).

And yes, since we want to get the actual pointer address "%px" is our 
only option :(

-- 
Kind regards,
Ivan Orlov