linux-kernel - Re: [PATCH v2 3/5] kunit: string-stream-test: Make it a separate module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f76aac0d-4f46-41b4-8379-d6397272e5f0@gmail.com>
Date: Thu, 27 Jun 2024 21:51:18 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Rae Moar <rmoar@...gle.com>
Cc: brendan.higgins@...ux.dev, davidgow@...gle.com,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH v2 3/5] kunit: string-stream-test: Make it a separate
 module

On 6/21/24 22:07, 'Rae Moar' via KUnit Development wrote:
> On Tue, Jun 18, 2024 at 1:03 PM Ivan Orlov <ivan.orlov0322@...il.com> wrote:
>>
>> Currently, the only way to build string-stream-test is by setting
>> CONFIG_KUNIT_TEST=y. However, CONFIG_KUNIT_TEST is a config option for
>> a different test (`kunit-test.c`).
>>
>> Introduce a new Kconfig entry in order to be able to build the
>> string-stream-test test as a separate module. Import the KUnit namespace
>> in the test so we could have string-stream functions accessible.
>>
>> Reviewed-by: David Gow <davidgow@...gle.com>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
> 
> Hello!
> 
> This is looking good to me other than the module description as noted
> by Jeff. That could be a separate patch since the rest of the series
> is looking good.
> 
> There is the checkpatch warning on the module description. But as
> David mentioned, the description looks ok to me. If there is a new
> version of this patch, it may be worth trying to get rid of the
> warning by lengthening the description.
> 
> But I am happy with this patch as is.
> 
> Reviewed-by: Rae Moar <rmoar@...gle.com>
> 
> Thanks!
> -Rae

Hi Rae,

Thank you for the review. I believe I'm going to send the V3 and add the 
module description there, to make the whole series as good as possible 
before it gets merged :)

Thank you so much for reviewing the series once again.

-- 
Kind regards,
Ivan Orlov