linux-kernel - Re: [PATCH v25 1/3] dt-bindings: reset: npcm: add clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 14:58:54 -0600
From: Rob Herring <robh@...nel.org>
To: Tomer Maimon <tmaimon77@...il.com>
Cc: kernel test robot <lkp@...el.com>, mturquette@...libre.com,
	sboyd@...nel.org, p.zabel@...gutronix.de,
	krzysztof.kozlowski+dt@...aro.org, tali.perry1@...il.com,
	joel@....id.au, venture@...gle.com, yuenn@...gle.com,
	benjaminfair@...gle.com, oe-kbuild-all@...ts.linux.dev,
	openbmc@...ts.ozlabs.org, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v25 1/3] dt-bindings: reset: npcm: add clock properties

On Thu, Jun 20, 2024 at 10:32:26AM +0300, Tomer Maimon wrote:
> Hi Rob and Krzysztof,
> 
> Could you please review this patch?

I would hope by v25 you'd know you just need to look at DT patchwork to 
see where you are in the queue. Pinging does nothing to help.

Furthermore, you waited a whole 2 days which isn't much.

> 
> Thanks,
> 
> Tomer
> 
> On Wed, 19 Jun 2024 at 09:20, kernel test robot <lkp@...el.com> wrote:
> >
> > Hi Tomer,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on clk/clk-next]
> > [also build test WARNING on linus/master pza/reset/next v6.10-rc4 next-20240618]
> > [cannot apply to pza/imx-drm/next]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url:    https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/dt-bindings-reset-npcm-add-clock-properties/20240619-093532
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> > patch link:    https://lore.kernel.org/r/20240618185819.2155595-2-tmaimon77%40gmail.com
> > patch subject: [PATCH v25 1/3] dt-bindings: reset: npcm: add clock properties
> > config: arm64-randconfig-051-20240619 (https://download.01.org/0day-ci/archive/20240619/202406191439.3NcnExKM-lkp@intel.com/config)
> > compiler: aarch64-linux-gcc (GCC) 13.2.0
> > dtschema version: 2024.6.dev1+g833054f
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240619/202406191439.3NcnExKM-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406191439.3NcnExKM-lkp@intel.com/
> >
> > dtcheck warnings: (new ones prefixed by >>)
> >    arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi:63.7-177.5: Warning (simple_bus_reg): /ahb/apb: simple-bus unit address format error, expected "f0000000"
> >    arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi:50.35-55.5: Warning (unique_unit_address_if_enabled): /ahb/reset-controller@...01000: duplicate unit-address (also used in node /ahb/clock-controller@...01000)
> >    arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: /: memory@0: 'device_type' is a required property
> >         from schema $id: http://devicetree.org/schemas/memory.yaml#
> >    arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: system-controller@...00000: compatible: ['nuvoton,npcm845-gcr', 'syscon'] is too short
> >         from schema $id: http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-gcr.yaml#
> >    arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: interrupt-controller@...f9000: 'ppi-partitions' does not match any of the regexes: '^v2m@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >         from schema $id: http://devicetree.org/schemas/interrupt-controller/arm,gic.yaml#
> >    arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: ahb: apb:ranges: [[0, 0, 4026531840, 3145728], [4293918720, 0, 4293918720, 90112]] is not of type 'boolean'
> >         from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
> > >> arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: reset-controller@...01000: '#clock-cells' is a required property
> >         from schema $id: http://devicetree.org/schemas/reset/nuvoton,npcm750-reset.yaml#
> > >> arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dtb: reset-controller@...01000: 'clocks' is a required property
> >         from schema $id: http://devicetree.org/schemas/reset/nuvoton,npcm750-reset.yaml#

While I think things are too noisy for these 0-day reports, this one 
rightfully shows the ABI break you are causing. You can't add new 
required properties.

Rob