[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <171946667846.1784649.14059031623063461479.robh@kernel.org>
Date: Wed, 26 Jun 2024 23:37:58 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: krzk+dt@...nel.org, ericwouds@...il.com, bert@...t.com,
conor+dt@...nel.org, tsbogend@...ha.franken.de, linux-mips@...r.kernel.org,
devicetree@...r.kernel.org, sander@...nheule.net, tglx@...utronix.de,
paulburton@...nel.org, john@...ozen.org, kabel@...nel.org,
daniel.lezcano@...aro.org, peterz@...radead.org, mail@...ger-koblitz.de,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 6/9] dt-bindings: interrupt-controller:
realtek,rtl-intc: Add rtl9300-intc
On Thu, 27 Jun 2024 16:33:14 +1200, Chris Packham wrote:
> Add a compatible string for the interrupt controller found on the
> rtl930x SoCs. The interrupt controller has registers for VPE1 so these
> are added as a second reg cell.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v3:
> - Use items to describe the regs property
> Changes in v2:
> - Set reg:maxItems to 2 to allow for VPE1 registers on the rtl9300. Add
> a condition to enforce the old limit on other SoCs.
> - Connor and Krzysztof offered acks on v1 but I think the changes here
> are big enough to void those.
>
> .../interrupt-controller/realtek,rtl-intc.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.example.dtb: interrupt-controller@...0: reg: [[12288, 24]] is too short
from schema $id: http://devicetree.org/schemas/interrupt-controller/realtek,rtl-intc.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240627043317.3751996-7-chris.packham@alliedtelesis.co.nz
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists