linux-kernel - RE: [EXT] [PATCH 26/43] wifi: nxpwifi: add sdio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 06:33:55 +0000
From: David Lin <yu-hao.lin@....com>
To: "Nemanov, Michael" <michael.nemanov@...com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>, "kvalo@...nel.org"
	<kvalo@...nel.org>, "francesco@...cini.it" <francesco@...cini.it>, Pete Hsieh
	<tsung-hsien.hsieh@....com>
Subject: RE: [EXT] [PATCH 26/43] wifi: nxpwifi: add sdio.c



> -----Original Message-----
> From: Nemanov, Michael <michael.nemanov@...com>
> Sent: Thursday, June 27, 2024 2:27 PM
> To: David Lin <yu-hao.lin@....com>; linux-wireless@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; briannorris@...omium.org;
> kvalo@...nel.org; francesco@...cini.it; Pete Hsieh
> <tsung-hsien.hsieh@....com>
> Subject: [EXT] [PATCH 26/43] wifi: nxpwifi: add sdio.c
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 6/27/2024 6:37 AM, David Lin wrote:
> >>
> >> On 6/21/2024 10:51 AM, David Lin wrote:
> >> ...
> >>> +
> >>> +/* This function unregisters the SDIO device.
> >>> + *
> >>> + * The SDIO IRQ is released, the function is disabled and driver
> >>> + * data is set to null.
> >>> + */
> >>> +static void
> >>> +nxpwifi_unregister_dev(struct nxpwifi_adapter *adapter) {
> >>> +     struct sdio_mmc_card *card = adapter->card;
> >>> +
> >>> +     if (adapter->card) {
> >>> +             card->adapter = NULL;
> >>> +             sdio_claim_host(card->func);
> >>> +             sdio_disable_func(card->func);
> >>> +             sdio_release_host(card->func);
> >>> +     }
> >>> +}
> >>
> >> Missing call to sdio_release_irq() ?
> >>
> >> Michael.
> >
> > sdio_release_irq() is called by nxpwifi_sdio_disable_host_int().
> >
> > David
> 
> Right, I see you calling it from nxpwifi_uninit_sw(). Maybe just align the
> comment then.
> 
> Michael.

I will modify the comment.

Thanks,
David