linux-kernel - Re: [PATCH 0/3] arm64: entry: Convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <319b42b3-271f-2e29-0171-a6f1a8b090d9@huawei.com>
Date: Thu, 27 Jun 2024 14:58:53 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Kees Cook <kees@...nel.org>
CC: <catalin.marinas@....com>, <will@...nel.org>, <oleg@...hat.com>,
	<tglx@...utronix.de>, <peterz@...radead.org>, <luto@...nel.org>,
	<wad@...omium.org>, <rostedt@...dmis.org>, <arnd@...db.de>,
	<ardb@...nel.org>, <broonie@...nel.org>, <mark.rutland@....com>,
	<rick.p.edgecombe@...el.com>, <leobras@...hat.com>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 0/3] arm64: entry: Convert to generic entry



On 2024/6/27 6:52, Kees Cook wrote:
> On Tue, Jun 25, 2024 at 05:27:56PM +0800, Jinjie Ruan wrote:
>> Currently, x86, Riscv, Loongarch use the generic entry. Convert arm64
>> to use the generic entry infrastructure from kernel/entry/*. The generic
>> entry makes maintainers' work easier and codes more elegant, which aslo
>> removed a lot of duplicate code.
>>
>> Jinjie Ruan (3):
>>   entry: Add some arch funcs to support arm64 to use generic entry
>>   arm64: Prepare to switch to generic entry
>>   arm64: entry: Convert to generic entry
>>
>>  arch/arm64/Kconfig                    |   1 +
>>  arch/arm64/include/asm/entry-common.h |  60 +++++
>>  arch/arm64/include/asm/ptrace.h       |   5 +
>>  arch/arm64/include/asm/stacktrace.h   |   5 +-
>>  arch/arm64/include/asm/syscall.h      |   6 +-
>>  arch/arm64/include/asm/thread_info.h  |  23 +-
>>  arch/arm64/kernel/entry-common.c      | 355 ++++++--------------------
>>  arch/arm64/kernel/ptrace.c            |  78 +++---
>>  arch/arm64/kernel/signal.c            |   3 +-
>>  arch/arm64/kernel/syscall.c           |  18 +-
>>  include/linux/entry-common.h          |  51 ++++
>>  kernel/entry/common.c                 |  49 +++-
>>  12 files changed, 294 insertions(+), 360 deletions(-)
>>  create mode 100644 arch/arm64/include/asm/entry-common.h
> 
> This is very cool! While the arm64 maintainers need to review it, I at
> least built and ran tests using the seccomp selftests which tends to be
> pretty sensitive to corner cases around syscall exit/entry things, and
> it passed just fine.

Kees, thank you for helping to test the code.

> 
> Tested-by: Kees Cook <kees@...nel.org>
>