linux-kernel - Re: [PATCH v7 1/4] driver core: don't always lock parent in shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024062751-itunes-silk-ae8d@gregkh>
Date: Thu, 27 Jun 2024 09:30:06 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Christoph Hellwig <hch@....de>
Cc: Stuart Hayes <stuart.w.hayes@...il.com>, linux-kernel@...r.kernel.org,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Martin Belanger <Martin.Belanger@...l.com>,
	Oliver O'Halloran <oohall@...il.com>,
	Daniel Wagner <dwagner@...e.de>, Keith Busch <kbusch@...nel.org>,
	Lukas Wunner <lukas@...ner.de>, David Jeffery <djeffery@...hat.com>,
	Jeremy Allison <jallison@....com>, Jens Axboe <axboe@...com>,
	Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v7 1/4] driver core: don't always lock parent in shutdown

On Thu, Jun 27, 2024 at 07:51:21AM +0200, Christoph Hellwig wrote:
> On Wed, Jun 26, 2024 at 02:46:47PM -0500, Stuart Hayes wrote:
> > Don't lock a parent device unless it is needed in device_shutdown. This
> > is in preparation for making device shutdown asynchronous, when it will
> > be needed to allow children of a common parent to shut down
> > simultaneously.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> .. but I guess this means async shutdown won't work well for busses
> that set this flag (just usb currently)?

USB can't do async shutdown due to the tree topology requirements here
so hopefully this should be ok.

thanks,

greg k-h