linux-kernel - Re: [PATCH 2/2] interconnect: qcom: Add MSM8953 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f278851-8c7b-4bb7-a967-fff477dc26eb@kernel.org>
Date: Thu, 27 Jun 2024 09:54:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Barnabás Czémán <barnabas.czeman@...nlining.org>,
 Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 Vladimir Lypak <vladimir.lypak@...il.com>
Subject: Re: [PATCH 2/2] interconnect: qcom: Add MSM8953 driver

On 26/06/2024 22:35, Barnabás Czémán wrote:
> From: Vladimir Lypak <vladimir.lypak@...il.com>


Thank you for your patch. There is something to discuss/improve.


> +
> +static const struct regmap_config msm8953_bimc_regmap_config = {
> +	.fast_io = true,
> +	.max_register = 0x5a000,
> +	.reg_bits = 32,
> +	.reg_stride = 4,
> +	.val_bits = 32,
> +};
> +
> +static const struct qcom_icc_desc msm8953_bimc = {
> +	.type = QCOM_ICC_BIMC,
> +	.bus_clk_desc = &bimc_clk,
> +	.nodes = msm8953_bimc_nodes,
> +	.num_nodes = ARRAY_SIZE(msm8953_bimc_nodes),
> +	.qos_offset = 0x8000,
> +	.regmap_cfg = &msm8953_bimc_regmap_config
> +};
> +
> +static struct qcom_icc_node *msm8953_pcnoc_nodes[] = {

This should be '* const '


Best regards,
Krzysztof