linux-kernel - Re: [PATCH v3] Staging: rtl8192e: rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 09:06:48 +0100
From: Yusef Aslam <yuzi54780@...look.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8192e: rtllib_rx: fix alignment

On Wed, 2024-06-26 at 19:32 +0200, Philipp Hortmann wrote:
> On 6/26/24 14:56, Yusef Aslam wrote:
> Hi Yusef,

Hi Philipp.

> The patch can be applied. Thanks for the change history.
> 
> But your patch description is not answering the why.
> 
> It could be: Fix alignment to increase readabiltiy.
> 
> For the first patch this is way to long and the indentations are
> really 
> a mess. Issue is that lines then get to long which leads again to 
> checkpatch issues. Please find some of my comments below.

Thank you for your comments and advice. They help me alot.