linux-kernel - RE: [PATCH v4 4/5] mei: vsc: Enhance SPI transfer of IVSC ROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 08:26:09 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: "Wu, Wentong" <wentong.wu@...el.com>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Chen,
 Jason Z" <jason.z.chen@...el.com>
Subject: RE: [PATCH v4 4/5] mei: vsc: Enhance SPI transfer of IVSC ROM


> 
> Before downloading firmware, a command response is required to identify
> the silicon. However, when downloading IVSC firmware, reading data from
> the SPI transfers with the IVSC ROM is not necessary. Therefore, the rx
> buffer of SPI transfer command is determined based on the specific request
> of the caller.
> 
> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Signed-off-by: Wentong Wu <wentong.wu@...el.com>
> Tested-by: Jason Chen <jason.z.chen@...el.com>

Acked-by: Tomas Winker <tomas.winker@...el.com> 

> ---
>  drivers/misc/mei/vsc-tp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> 876330474444..1618cca9a731 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void
> *obuf, void *ibuf, size_t len)
>  		return ret;
>  	}
> 
> -	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len);
> +	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : NULL, len);
>  	if (ret)
>  		return ret;
> 
> --
> 2.34.1