linux-kernel - Re: [PATCH net-next 1/5] netdevice: convert private flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0b4bea5-58bc-46b7-bb47-110f4c5d4132@intel.com>
Date: Thu, 27 Jun 2024 11:48:52 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
	<dsahern@...nel.org>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Andrew Lunn
	<andrew@...n.ch>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31)
 to bitfields

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 26 Jun 2024 07:54:21 -0700

> On Tue, 25 Jun 2024 13:44:28 +0200 Alexander Lobakin wrote:
>> -		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %llx\n",
>> +		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %x\n",
> 
> compiler says %lx
> 
> net/8021q/vlanproc.c: In function ‘vlandev_seq_show’:
> net/8021q/vlanproc.c:241:69: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
>   241 |                    "%s  VID: %d  REORDER_HDR: %i  dev->priv_flags: %x\n",
>       |                                                                    ~^
>       |                                                                     |
>       |                                                                     unsigned int
>       |                                                                    %lx
>   242 |                    vlandev->name, vlan->vlan_id,
>   243 |                    (int)(vlan->flags & 1), vlandev->priv_flags);
>       |                                            ~~~~~~~~~~~~~~~~~~~       
>       |                                                   |
>       |                                                   long unsigned int

Yeah, GCC wants %lx here, but Clang wants %x since priv_flags is
declared as long:32 >_<
I think I'll add a cast here.

Thanks,
Olek