[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <jxfdfponl5eo42imhsut7rckqafolnqooifpn77fgsn26elkwi@rsvxfjzvkjxp>
Date: Thu, 27 Jun 2024 13:28:33 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Ekansh Gupta <quic_ekangupt@...cinc.com>
Cc: srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org,
gregkh@...uxfoundation.org, quic_bkumar@...cinc.com, linux-kernel@...r.kernel.org,
quic_chennak@...cinc.com, dri-devel@...ts.freedesktop.org, arnd@...db.de
Subject: Re: [PATCH v2] misc: fastrpc: Move fastrpc driver to misc/fastrpc/
On Thu, Jun 27, 2024 at 02:16:27PM GMT, Ekansh Gupta wrote:
> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned
> to be added for PD notifications and other missing features. Adding
> and maintaining new files from within fastrpc directory would be easy.
>
> Example of feature that is being planned to be introduced in a new C
> file:
> https://lore.kernel.org/all/20240606165939.12950-6-quic_ekangupt@quicinc.com/
>
> Signed-off-by: Ekansh Gupta <quic_ekangupt@...cinc.com>
> ---
> Changes in v2:
> - Updated Kconfig.
>
> MAINTAINERS | 2 +-
> drivers/misc/Kconfig | 13 +------------
> drivers/misc/Makefile | 2 +-
> drivers/misc/fastrpc/Kconfig | 16 ++++++++++++++++
> drivers/misc/fastrpc/Makefile | 2 ++
> drivers/misc/{ => fastrpc}/fastrpc.c | 0
> 6 files changed, 21 insertions(+), 14 deletions(-)
> create mode 100644 drivers/misc/fastrpc/Kconfig
> create mode 100644 drivers/misc/fastrpc/Makefile
> rename drivers/misc/{ => fastrpc}/fastrpc.c (100%)
> diff --git a/drivers/misc/fastrpc/Kconfig b/drivers/misc/fastrpc/Kconfig
> new file mode 100644
> index 000000000000..7179a44eda84
> --- /dev/null
> +++ b/drivers/misc/fastrpc/Kconfig
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Qualcomm FastRPC devices
> +#
> +
> +config QCOM_FASTRPC
> + tristate "Qualcomm FastRPC"
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on RPMSG
> + select DMA_SHARED_BUFFER
> + select QCOM_SCM
> + help
> + Provides a communication mechanism that facilitate high-speed
> + Remote Procedure Call (RPC) mechanisms between the host CPU and
> + offload processors Qualcomm Digital Signal Processors (DSPs).
> + Say M if you want to enable this module.
> \ No newline at end of file
Nit: ^^
Nevertheless:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
--
With best wishes
Dmitry
Powered by blists - more mailing lists