linux-kernel - Re: [PATCH net-next v3 02/10] net: pcs: xpcs: Split up xpcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adfbc8c2-f39e-4aee-a879-1ae992689882@lunn.ch>
Date: Thu, 27 Jun 2024 15:07:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Serge Semin <fancer.lancer@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	Jose Abreu <Jose.Abreu@...opsys.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Sagar Cheluvegowda <quic_scheluve@...cinc.com>,
	Abhishek Chauhan <quic_abchauha@...cinc.com>,
	Andrew Halaney <ahalaney@...hat.com>,
	Jiawen Wu <jiawenwu@...stnetic.com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>,
	Tomer Maimon <tmaimon77@...il.com>, openbmc@...ts.ozlabs.org,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 02/10] net: pcs: xpcs: Split up xpcs_create()
 body to sub-functions

On Thu, Jun 27, 2024 at 03:41:22AM +0300, Serge Semin wrote:
> As an initial preparation before adding the fwnode-based DW XPCS device
> support let's split the xpcs_create() function code up to a set of the
> small sub-functions. Thus the xpcs_create() implementation will get to
> look simpler and turn to be more coherent. Further updates will just touch
> the new sub-functions a bit: add platform-specific device info, add the
> reference clock getting and enabling.
> 
> The xpcs_create() method will now contain the next static methods calls:
> 
> xpcs_create_data() - create the DW XPCS device descriptor, pre-initialize
> it' fields and increase the mdio device refcount-er;
> 
> xpcs_init_id() - find XPCS ID instance and save it in the device
> descriptor;
> 
> xpcs_init_iface() - find MAC/PCS interface descriptor and perform
> basic initialization specific to it: soft-reset, disable polling.
> 
> The update doesn't imply any semantic change but merely makes the code
> looking simpler and more ready for adding new features support.
> 
> Note the xpcs_destroy() has been moved to being defined below the
> xpcs_create_mdiodev() function as the driver now implies having the
> protagonist-then-antagonist functions definition order.
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew