[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2024062723-unwed-sleeve-47b7@gregkh>
Date: Thu, 27 Jun 2024 16:23:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Nikita Travkin <nikita@...n.ru>,
Neil Armstrong <neil.armstrong@...aro.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/7] usb: typec: ucsi: rework glue driver interface
On Tue, Jun 25, 2024 at 05:54:25PM +0300, Dmitry Baryshkov wrote:
> The interface between UCSI and the glue driver is very low-level. It
> allows reading the UCSI data from any offset (but in reality the UCSI
> driver reads only VERSION, CCI an MESSAGE_IN data). All event handling
> is to be done by the glue driver (which already resulted in several
> similar-but-slightly different implementations). It leaves no place to
> optimize the write-read-read sequence for the command execution (which
> might be beneficial for some of the drivers), etc.
>
> The patchseries attempts to restructure the UCSI glue driver interface
> in order to provide sensible operations instead of a low-level read /
> write calls.
>
> If this approach is found to be acceptable, I plan to further rework the
> command interface, moving reading CCI and MESSAGE_IN to the common
> control code, which should simplify driver's implementation and remove
> necessity to split quirks between sync_control and read_message_in e.g.
> as implemented in the ucsi_ccg.c.
>
> Note, the series was tested only on the ucsi_glink platforms. Further
> testing is appreciated.
>
> Depends: [1], [2]
>
> [1] https://lore.kernel.org/linux-usb/20240612124656.2305603-1-fabrice.gasnier@foss.st.com/
>
> [2] https://lore.kernel.org/linux-usb/20240621-ucsi-yoga-ec-driver-v8-1-e03f3536b8c6@linaro.org/
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
This doesn't apply to my tree at all, can you rebase and add Heikki's
review and resend?
thanks,
greg k-h
Powered by blists - more mailing lists