linux-kernel - Re: [PATCH v2 0/2] Add MPS MP5920 Host-Swap controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 07:30:48 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Alex Vdovydchenko <keromvp@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sean Anderson <sean.anderson@...ux.dev>,
 Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-i2c@...r.kernel.org, Alex Vdovydchenko <xzeol@...oo.com>
Subject: Re: [PATCH v2 0/2] Add MPS MP5920 Host-Swap controller

On 6/27/24 02:01, Alex Vdovydchenko wrote:
> This series of patches adds the MP5920 Host-swap controller, which is used
> as a protection and control IC for devices that are being inserted into a live
> backplane. MP5920 acts as a voltage regulator (MP5911 etc) supervisor. IC
> utilizes pmbus and provides monitoring, statistics and limits to electrical and
> thermal characteristics such as:
> - input and output voltage
> - output current
> - output power
> - IC temperature
> 
> One must take into account the nonlinear character of readings, so there will be
> a statistical error in the range 5–10 percents, depending on current passing
> through. In order to use the IC, make sure to specify a valid I2C address
> (consult to datasheet and dts-bindings)
> MP5920 datasheet: https://www.monolithicpower.com/en/mp5920.html
> 
> Changes in v2:
>    -  fixed typos

... and ignored all other feedback without explaining the reasons.

I am not even going to review this version.

Guenter