[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAA+D8AMnevQCLfExKUk2bo2wfCHjn8Bp9cVuRaDsW_Zt4aK+fA@mail.gmail.com>
Date: Thu, 27 Jun 2024 10:14:59 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com, broonie@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts
On Wed, Jun 26, 2024 at 9:35 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 26/06/2024 11:34, Krzysztof Kozlowski wrote:
> >>>> items:
> >>>> - description: WAKEUPMIX Audio XCVR Interrupt 1
> >>>> - description: WAKEUPMIX Audio XCVR Interrupt 2
> >>>> + - description: SPDIF wakeup interrupt from PHY
> >>>> minItems: 1
> >>>>
> >>>> clocks:
> >>>> @@ -88,6 +89,7 @@ required:
> >>>> - dma-names
> >>>>
> >>>> allOf:
> >>>> + - $ref: dai-common.yaml#
> >>>> - if:
> >>>> properties:
> >>>> compatible:
> >>>> @@ -112,7 +114,7 @@ allOf:
> >>>> else:
> >>>> properties:
> >>>> interrupts:
> >>>> - maxItems: 1
> >>>> + maxItems: 3
> >>>
> >>> I have doubts this was tested. The existing example should fail,
> >>> although I did not see any reports. Not sure why.
> >>
> >> it is tested, because the minItems is 1. so the example can pass
> >>
> >
> > That's a very unexpected change in dtschema. It indeed passes, but is
> > not correct. Why interrupts are flexible? This should be constrained.
> > Let's wait for Rob's confirmation that this is not a bug in dtschema.
>
> Yep we need here minItems as well, so this is strictly constrained or
> please explain why this should be flexible.
>
Ok, will add minitems:3 here, and update example.
Best regards
Shengjiu Wang
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists