linux-kernel - Re: [PATCH] riscv: entry: always initialize regs->a0 to -ENOSYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+HfNhV2d53G-ZPDXUkSTP-AzhqXs54XZuCiYjR=06A1+oq_A@mail.gmail.com>
Date: Thu, 27 Jun 2024 17:48:55 +0200
From: Björn Töpel <bjorn@...nel.org>
To: Celeste Liu <coelacanthushex@...il.com>
Cc: linux-riscv@...ts.infradead.org, Björn Töpel <bjorn@...osinc.com>, 
	"Dmitry V . Levin" <ldv@...ace.io>, linux-kernel@...r.kernel.org, Guo Ren <guoren@...nel.org>, 
	Palmer Dabbelt <palmer@...osinc.com>, 
	Emil Renner Berthing <emil.renner.berthing@...onical.com>, Felix Yan <felixonmars@...hlinux.org>, 
	Ruizhe Pan <c141028@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] riscv: entry: always initialize regs->a0 to -ENOSYS

On Thu, 27 Jun 2024 at 16:29, Celeste Liu <coelacanthushex@...il.com> wrote:
>
> On 2024-06-27 22:08, Björn Töpel wrote:
>
> > Celeste Liu <coelacanthushex@...il.com> writes:
> >
> >> Otherwise when the tracer changes syscall number to -1, the kernel fails
> >> to initialize a0 with -ENOSYS and subsequently fails to return the error
> >> code of the failed syscall to userspace. For example, it will break
> >> strace syscall tampering.
> >>
> >> Fixes: 52449c17bdd1 ("riscv: entry: set a0 = -ENOSYS only when syscall != -1")
> >> Cc: stable@...r.kernel.org
> >> Signed-off-by: Celeste Liu <CoelacanthusHex@...il.com>
> >
> > Reported-by: "Dmitry V. Levin" <ldv@...ace.io>
> > Reviewed-by: Björn Töpel <bjorn@...osinc.com>
>
> Patch v2 has been sent.

For future patches; You don't need to respin a patch to add tags. The
tooling will pick up the tags automatically.