[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <D2BS0YMA48BG.1PEPFC3KMFV8N@kernel.org>
Date: Fri, 28 Jun 2024 18:04:52 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Conor Dooley" <conor@...nel.org>, "Erez Geva" <erezgeva@...ime.org>
Cc: <linux-mtd@...ts.infradead.org>, "Tudor Ambarus"
<tudor.ambarus@...aro.org>, "Pratyush Yadav" <pratyush@...nel.org>,
<linux-kernel@...r.kernel.org>, "Miquel Raynal"
<miquel.raynal@...tlin.com>, "Richard Weinberger" <richard@....at>,
"Vignesh Raghavendra" <vigneshr@...com>, <devicetree@...r.kernel.org>, "Rob
Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
"Conor Dooley" <conor+dt@...nel.org>, "Erez Geva" <ErezGeva2@...il.com>
Subject: Re: [PATCH 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR
chip
Hi,
On Fri Jun 28, 2024 at 5:57 PM CEST, Conor Dooley wrote:
> On Fri, Jun 28, 2024 at 04:03:27PM +0200, Erez Geva wrote:
> > From: Erez Geva <ErezGeva2@...il.com>
> >
> > Add Macronix SPI-NOR mx25l12833f.
> >
> > Signed-off-by: Erez Geva <ErezGeva2@...il.com>
>
> Should the email in here and in the From: field be your nwtime one?
> Otherwise
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Actually, you're not supposed to add any compatibles to this list.
>From the binding:
description:
SPI NOR flashes compatible with the JEDEC SFDP standard or which may be
identified with the READ ID opcode (0x9F) do not deserve a specific
compatible. They should instead only be matched against the generic
"jedec,spi-nor" compatible.
I presume the Macronix flash does support the read id opcode.
-michael
Powered by blists - more mailing lists