linux-kernel - Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667edfb08cbf3_eca1e370ea@njaxe.notmuch>
Date: Fri, 28 Jun 2024 18:07:12 +0200
From: Matteo Martelli <matteomartelli3@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Maxime Ripard <mripard@...nel.org>, 
 Liam Girdwood <lgirdwood@...il.com>, 
 Jaroslav Kysela <perex@...ex.cz>, 
 Takashi Iwai <tiwai@...e.com>, 
 Chen-Yu Tsai <wens@...e.org>, 
 Jernej Skrabec <jernej.skrabec@...il.com>, 
 Samuel Holland <samuel@...lland.org>, 
 Marcus Cooper <codekipper@...il.com>, 
 Clément Péron <peron.clem@...il.com>, 
 linux-sound@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, 
 linux-sunxi@...ts.linux.dev, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s
 mode

Mark Brown wrote:
> On Fri, Jun 07, 2024 at 10:04:43AM +0200, Matteo Martelli wrote:
> > Maxime Ripard wrote:
> > > > -	/*
> > > > -	 * DAI clock polarity
> > > > -	 *
> > > > -	 * The setup for LRCK contradicts the datasheet, but under a
> > > > -	 * scope it's clear that the LRCK polarity is reversed
> > > > -	 * compared to the expected polarity on the bus.
> > > > -	 */
> > > 
> > > I think we should keep that comment somewhere.
> > 
> > I think that keeping that comment would be very misleading since the LRCLK
> > setup would not contradict the datasheet anymore [1][2].
> > 
> > Also, do you recall any details about the mentioned scope test setup? Was i2s
> > mode tested in that occasion? It would help clarify the situation.
> > 
> > Could anyone verify this patch against H3/H6 SoCs?
> 
> Any news on any of this?

Not on my side, unfortunately I cannot test the fix against H3/H6 SoCs.

Matteo Martelli