linux-kernel - Re: [PATCH] zsmalloc: rename class stat mutators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240628022218.GE15925@google.com>
Date: Fri, 28 Jun 2024 11:22:18 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Andrew Morton <akpm@...ux-foundation.org>,
	Chengming Zhou <chengming.zhou@...ux.dev>
Cc: Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH] zsmalloc: rename class stat mutators

On (24/06/28 10:42), Sergey Senozhatsky wrote:
> A cosmetic change.
> 
> o Rename class_stat_inc() and class_stat_dec() to class_stat_add()
>   and class_stat_sub() correspondingly. inc/dec are usually associated
>   with +1/-1 modifications, while zsmlloc can modify stats by up
>   to ->objs_per_zspage. Use add/sub (follow atomics naming).
> 
> o Rename zs_stat_get() to class_stat_read()
>   get() is usually associated with ref-counting and is paired with put().
>   zs_stat_get() simply reads class stat so rename to reflect it.
>   (This also follows atomics naming).

I think I will resend this after Chengming patches land.