linux-kernel - Re: [PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <884684ce-53b1-48db-8dcb-6b2bcd0d151d@valvesoftware.com>
Date: Fri, 28 Jun 2024 10:25:58 -0700
From: John Schoenick <johns@...vesoftware.com>
To: Matthew Schwartz <mattschwartz@...ail.gwu.edu>, Hamza Mahfooz
	<hamza.mahfooz@....com>
CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Mario
 Limonciello <mario.limonciello@....com>, Kyle Gospodnetich
	<me@...egospodneti.ch>, Hans de Goede <hdegoede@...hat.com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>, Matthew
 Schwartz <mattschwartz@....edu>
Subject: Re: [PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve
 Galileo


On 6/27/24 5:17 PM, Matthew Schwartz wrote:
> On Thu, Jun 27, 2024 at 2:28 PM Hamza Mahfooz <hamza.mahfooz@....com> wrote:
>> On 6/27/24 16:30, Matthew Schwartz wrote:
>>> From: John Schoenick <johns@...vesoftware.com>
>> Since this patch is from John, you would need his S-o-b in here as well
>> (assuming you have his permission to add it).
> This patch will be pending approval from them in that case. The panel quirk
> follows the same structure as the Steam Deck Jupiter revision, but the quirk
> has only been signed during merges by people who were not the original author.
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/b90ac393

Hey, thanks for taking the initiative to upstream this -- feel free to 
add my S-o-b

>>
>>> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
>>>
>>> Suggested-by: John Schoenick <johns@...vesoftware.com>
>>> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
>>> Signed-off-by: Matthew Schwartz <mattschwartz@....edu>
>>> ---
>>>    drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>>>    1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> index 3d127127e7cb..ac8319d38e37 100644
>>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>>>                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>>                },
>>>                .driver_data = (void *)&lcd800x1280_rightside_up,
>>> +     }, {    /* Valve Steam Deck */
>>> +             .matches = {
>>> +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>> +             },
>>> +             .driver_data = (void *)&lcd800x1280_rightside_up,
> Unless I get a S-o-b, is authoring a different DMI check the only solution
> to get a functioning panel quirk upstreamed for the Galileo revision?
> Not quite sure how I'd maintain conformity with the existing Jupiter
> quirk while also writing something original here.
>
>>>        }, {    /* VIOS LTH17 */
>>>                .matches = {
>>>                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
>> --
>> Hamza
>>
> --
> Matt
>