linux-kernel - Re: [PATCH v2] arm64: dts: imx8mm-verdin: add TPM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zn4ifj63+OwQPXx7@dragon>
Date: Fri, 28 Jun 2024 10:39:58 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Vitor Soares <ivitro@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Vitor Soares <vitor.soares@...adex.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mm-verdin: add TPM device

On Thu, Jun 27, 2024 at 11:48:39AM +0100, Vitor Soares wrote:
> From: Vitor Soares <vitor.soares@...adex.com>
> 
> Add TPM device found on Verdin iMX8M Mini PID4 0090 variant.
> 
> While adding the node, rename `pinctrl_pmic_tpm_ena` to
> `pinctrl_tpm_spi_cs`.
> 
> Signed-off-by: Vitor Soares <vitor.soares@...adex.com>
> ---
> v1->v2
>   - rename `pinctrl_pmic_tpm_ena` to `pinctrl_tpm_spi_cs`.
> 
>  .../boot/dts/freescale/imx8mm-verdin.dtsi      | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> index 98544741ce17..6e066bd5d982 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -228,15 +228,16 @@ &ecspi2 {
>  	pinctrl-0 = <&pinctrl_ecspi2>;
>  };
>  
> -/* Verdin CAN_1 (On-module) */
> +/* On-module SPI */
>  &ecspi3 {
>  	#address-cells = <1>;
>  	#size-cells = <0>;
> -	cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
> +	cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>, <&gpio4 19 GPIO_ACTIVE_LOW>;
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&pinctrl_ecspi3>;
> +	pinctrl-0 = <&pinctrl_ecspi3>, <&pinctrl_tpm_spi_cs>;
>  	status = "okay";
>  
> +	/* Verdin CAN_1 */
>  	can1: can@0 {
>  		compatible = "microchip,mcp251xfd";
>  		clocks = <&clk40m>;
> @@ -246,6 +247,12 @@ can1: can@0 {
>  		reg = <0>;
>  		spi-max-frequency = <8500000>;
>  	};
> +
> +	verdin_som_tpm: tpm@1 {
> +		compatible = "atmel,attpm20p", "tcg,tpm_tis-spi";
> +		reg = <0x1>;
> +		spi-max-frequency = <36000000>;
> +	};
>  };
>  
>  /* Verdin ETH_1 (On-module PHY) */
> @@ -808,8 +815,7 @@ &iomuxc {
>  	pinctrl-0 = <&pinctrl_gpio1>, <&pinctrl_gpio2>,
>  		    <&pinctrl_gpio3>, <&pinctrl_gpio4>,
>  		    <&pinctrl_gpio7>, <&pinctrl_gpio8>,
> -		    <&pinctrl_gpio_hog1>, <&pinctrl_gpio_hog2>, <&pinctrl_gpio_hog3>,
> -		    <&pinctrl_pmic_tpm_ena>;
> +		    <&pinctrl_gpio_hog1>, <&pinctrl_gpio_hog2>, <&pinctrl_gpio_hog3>;
>  
>  	pinctrl_can1_int: can1intgrp {
>  		fsl,pins =
> @@ -1111,7 +1117,7 @@ pinctrl_sai5: sai5grp {
>  	};
>  
>  	/* control signal for optional ATTPM20P or SE050 */
> -	pinctrl_pmic_tpm_ena: pmictpmenagrp {
> +	pinctrl_tpm_spi_cs: pmictpmenagrp {

The node name should probably be updated to match pinctrl label?

Shawn

>  		fsl,pins =
>  			<MX8MM_IOMUXC_SAI1_TXD7_GPIO4_IO19		0x106>;	/* PMIC_TPM_ENA */
>  	};
> -- 
> 2.34.1
>